Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support filters in entry & agent command #50

Closed
wants to merge 26 commits into from

Conversation

FedeNQ
Copy link
Contributor

@FedeNQ FedeNQ commented Nov 15, 2023

Description

  • Make required changes in entry.proto to support filtering while using count/show command.
  • Make required changes in agent.proto to support filtering while using count/list command.

loveyana and others added 23 commits May 12, 2022 15:21
* proto/agent: add JWT SVID privileged API

Signed-off-by: Yuhan Li <[email protected]>

* Fix comment lint problem

Signed-off-by: Yuhan Li <[email protected]>
update bool name

Co-authored-by: Andrew Harding <[email protected]>
Signed-off-by: Faisal Memon <[email protected]>
Update permission denied details

Co-authored-by: Andrew Harding <[email protected]>
Signed-off-by: Faisal Memon <[email protected]>
Signed-off-by: Faisal Memon <[email protected]>
This change updates links to github repositories to incorporate renames
to their default branches.

Signed-off-by: Andrew Harding <[email protected]>
Also update go.mod to use latest conventions with indirect dependencies.

Signed-off-by: Ryan Turner <[email protected]>
This change is in reference to a new SPIRE feature discussed in spiffe/spire#2700

Signed-off-by: Dennis Gove <[email protected]>
Per comment spiffe/spire#3445 (comment) it was decided to
1. Rename the TTL field to X509SvidTtl
2. Add the new JwtSvidTtl field

This change augments commit spiffe@3c5e450

Signed-off-by: Dennis Gove <[email protected]>
Signed-off-by: Guilherme Carvalho <[email protected]>
* Add missing CanReAttest agent listing filter and output mask

Signed-off-by: Guilherme Carvalho <[email protected]>

---------

Signed-off-by: Guilherme Carvalho <[email protected]>
* Introduce an API for key management

Introduces an API that allows callers to manage key
preparation/activation/rotation/revocation in SPIRE. 
Update bundle API to propagate tainted keys.
Add an endpoint to Agent API to post current agent status.

---------

Signed-off-by: Evan Gilman <[email protected]>
Signed-off-by: Marcos Yacob <[email protected]>
Co-authored-by: Evan Gilman <[email protected]>
* Update get local authorities to return authorities by state instead of a list
* Remove Status from responses

Signed-off-by: Marcos Yacob <[email protected]>
@FedeNQ FedeNQ changed the title Support filters in entry count Support filters in entry & agent command Nov 30, 2023
Copy link
Member

@amartinezfayo amartinezfayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @FedeNQ, this looks good!

proto/spire/api/server/agent/v1/agent.proto Show resolved Hide resolved
Copy link
Member

@amartinezfayo amartinezfayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that this PR needs to be merged in the next branch, not in the main branch, so it should be changed to point to next.

Signed-off-by: FedeNQ <[email protected]>
@FedeNQ FedeNQ changed the base branch from main to next January 12, 2024 13:18
@FedeNQ FedeNQ marked this pull request as draft January 12, 2024 14:21
@amartinezfayo
Copy link
Member

Closing in favor of #52.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants